Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Releasenotes 1.9.0 #590

Merged
merged 3 commits into from
May 3, 2018
Merged

Releasenotes 1.9.0 #590

merged 3 commits into from
May 3, 2018

Conversation

stayallive
Copy link
Collaborator

Release notes and doc updates for 1.9.0.

1.8.4...master

@stayallive stayallive requested a review from Jean85 May 3, 2018 07:31
Copy link
Collaborator

@Jean85 Jean85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few nitpicking, but LGTM 👍

CHANGELOG.md Outdated
@@ -1,8 +1,17 @@
# CHANGELOG

## Unreleased
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please leave the unreleased header at the top.

- Fixed undefined variable (#588)
- Fix for exceptions throwing exceptions when setting event id (#587)
- Fix monolog handler not accepting Throwable (#586)
- Add `excluded_exceptions` option to exclude exceptions and their extending exceptions (#583)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add here that is a 2.x forward compat functionality.

Copy link
Collaborator Author

@stayallive stayallive May 3, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should do that yet. We don't know how and if when we release (bit of expectation management), when we do we can create the upgrade guide with all options that are forward compatible and which need removing / updating.

Note that excluded is currently not documented for 1.x and I intend to leave it that way (but ofcourse do mention it in the upgrade guide later). 😄


.. describe:: excluded_exceptions

Exception that should not be reported, exceptions extending exceptions in this list will also
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here too, so it will be clear.

Copy link
Collaborator

@Jean85 Jean85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the response, hence LGTM! 👍

@stayallive stayallive merged commit 496a6ec into master May 3, 2018
@stayallive stayallive deleted the releasenotes-1-9-0 branch May 3, 2018 12:05
@Jean85 Jean85 mentioned this pull request May 3, 2018
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants